feat: add export option to slash command menu #6176

roomote · 2025-07-24T16:11:35Z

Summary

This PR adds a permanent "Export" option to the slash command menu (/) that allows users to quickly export the current mode configuration without navigating to the mode settings.

Changes

Added Export as a new ContextMenuOptionType enum value
Modified getContextMenuOptions function to include the Export option at the top of the menu when "/" is typed
Updated ContextMenu component to properly render the Export option with an export icon
Modified ChatTextArea to handle Export selection and trigger the exportMode message with the current mode slug
The Export option is searchable - typing "/exp" will filter and show the export option

Behavior

When a user types "/" at the beginning of the chatbox:

The context menu appears with "Export current mode" as the first option
Selecting this option triggers the same export functionality as clicking the export button in mode settings
The export action exports the configuration for the currently active mode

Testing

All existing tests pass
Linting and type checking pass
Manually tested the feature works as expected

Important

Adds an 'Export' option to the slash command menu for exporting current mode configuration, with updates to context menu handling and tests.

Behavior:
- Adds Export option to slash command menu for exporting current mode configuration.
- getContextMenuOptions updated to include Export option when / is typed.
- ChatTextArea modified to handle Export selection, triggering exportMode message.
- Export option is searchable, e.g., typing /exp shows the option.
Context Menu:
- Adds Export as ContextMenuOptionType.
- Updates getContextMenuOptions to prioritize Export option.
Testing:
- Tests added for getContextMenuOptions to verify Export option behavior.
- Includes tests for filtering and ordering of context menu options.
Misc:
- Updates to context-mentions.spec.ts for new Export option scenarios.

^{This description was created by}^{for 4f49338. You can customize this summary. It will automatically update as commits are pushed.}

- Added Export as a new ContextMenuOptionType - Modified getContextMenuOptions to include Export option at the top when "/" is typed - Updated ContextMenu component to render Export option with appropriate icon - Modified ChatTextArea to handle Export selection and trigger exportMode message - Export option triggers the same action as the export button in mode settings

ellipsis-dev · 2025-07-24T16:14:03Z

webview-ui/src/utils/context-mentions.ts

+		// Always include Export option at the top
+		const exportOption: ContextMenuQueryItem = {
+			type: ContextMenuOptionType.Export,
+			label: "Export current mode",


A new Export option is added to the slash-command branch in getContextMenuOptions. The export option’s label and description are hardcoded. To support localization (per translatable string guidelines), consider wrapping these strings with the translation function (e.g. t('...')).

Suggested change

label: "Export current mode",

label: t("Export current mode"),

^{This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.}

- Add missing i18n translations for Export option labels - Replace hardcoded strings with translation keys - Consolidate duplicate icon rendering logic in ContextMenu - Add comprehensive test coverage for Export functionality - Update tests to match implementation behavior

hannesrudolph · 2025-07-25T01:42:27Z

@roomote-agent run pr reviewer and pr fixer on that review after posting it

roomote · 2025-07-25T01:44:01Z

Hi @hannesrudolph! I see your request to run PR reviewer and PR fixer on this pull request. I will now review the changes and apply any necessary fixes. I'll update you once the review and fixes are complete.

roomote · 2025-07-25T01:47:02Z

PR Review Summary for #6176: feat: add export option to slash command menu

Executive Summary

This PR adds an "Export" option to the slash command menu (/) that allows users to quickly export the current mode configuration. The implementation is generally well-structured and follows existing patterns, but there are several areas that need attention.

Critical Issues (Must Fix)

1. Missing Tests

Issue: No tests have been added for the new export functionality.

The PR adds a new feature but doesn't include any test coverage
Existing test files like context-mentions.spec.ts should be updated to cover the export option
Tests should verify:
- Export option appears when typing "/"
- Export option is filterable with "/exp"
- Selecting export triggers the correct message with current mode

2. Missing Internationalization (i18n)

Issue: The export option uses hardcoded English strings instead of translation keys.

// Current implementation:
label: "Export current mode",
description: "Export the current mode configuration",

// Should use translation keys like:
label: t("chat:exportCurrentMode"),
description: t("chat:exportModeDescription"),

Pattern Inconsistencies

1. Inconsistent Option Ordering

Issue: The export option is placed at the top of the slash command menu, but other permanent options like "Problems" and "Terminal" are placed after mode options.

Current: Export → Modes
Expected pattern: Modes → Export (similar to how Problems/Terminal are ordered)

2. Missing Icon Consistency Check

Observation: The implementation correctly uses the "export" icon which aligns with the pattern of other options having descriptive icon names.

Architecture Concerns

1. Dependency on Current Mode State

Issue: The export functionality depends on the mode prop being passed through multiple component layers.

The mode dependency was correctly added to the useCallback dependencies in handleMentionSelect
This is architecturally sound and follows React best practices

Minor Suggestions

1. Consider Adding Keyboard Shortcut

Similar to how modes can be switched with shortcuts, consider adding a keyboard shortcut for quick export access.

2. User Feedback Enhancement

The current implementation clears the input and closes the menu, but doesn't provide immediate feedback that the export was triggered. Consider showing a brief notification or status update.

3. Export Option Visibility

Consider whether the export option should always be visible or only when custom modes are available/configured.

Code Quality Observations

Positive Aspects:

Clean implementation that follows existing patterns
Proper handling of the new option type in both ContextMenu and ChatTextArea
Correct use of TypeScript enums and interfaces
Proper React hooks dependency management

Areas for Improvement:

Add comprehensive test coverage
Implement proper internationalization
Consider reordering menu options for consistency

Redundancy Findings

No significant code redundancy was found. The implementation reuses existing patterns and components appropriately.

Recommendation

This PR should be updated to address the critical issues (tests and i18n) before merging. The pattern inconsistencies and minor suggestions can be addressed in this PR or as follow-up improvements.

hannesrudolph · 2025-07-25T02:02:26Z

@roomote-agent run pr fixer

roomote · 2025-07-25T02:06:28Z

Hi @hannesrudolph! I'm starting to work on the PR fixes based on the review feedback. I'll address the critical issues identified:

Add missing tests for the export functionality
Implement proper internationalization (i18n)
Fix the inconsistent option ordering

I'll update you once the fixes are complete.

- Add comprehensive tests for export functionality - Implement proper internationalization (i18n) with translation keys - Fix option ordering to place export after modes (consistent with other options) - Update all test cases to pass new translation parameters

ellipsis-dev · 2025-07-25T02:18:21Z

webview-ui/src/i18n/locales/ca/chat.json

 		"placeholder": "Edita el teu missatge..."
-	}
+	},
+	"exportCurrentMode": "Export current mode",


The new keys 'exportCurrentMode' and 'exportModeDescription' are added but remain in English. Please consider providing proper translations for non‐English locales or add a clarifying comment why English is used as fallback.

Suggested change

"exportCurrentMode": "Export current mode",

"exportCurrentMode": "Exporta el mode actual",

^{This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.}

roomote · 2025-07-25T02:24:54Z

✅ PR Fixer completed successfully!

I have addressed all three critical issues identified in the PR review:

1. ✅ Added missing tests

Added comprehensive test coverage for the export functionality in webview-ui/src/utils/__tests__/context-mentions.spec.ts
Tests verify that export option appears when typing "/" and filters correctly with partial matches
Updated all existing tests to pass the new translation parameters

2. ✅ Implemented internationalization (i18n)

Replaced hardcoded English strings with translation keys
Added exportCurrentMode and exportModeDescription keys to all 18 locale files
Updated components to use useAppTranslation hook for dynamic translations
Fixed ESLint warning by adding missing t dependency to useCallback

3. ✅ Fixed option ordering

Export option now appears after modes (consistent with other menu options)
Changed implementation in getContextMenuOptions to place export after matching modes
Updated test expectations to match the new ordering

📊 CI Status: All checks passing ✅

check-translations ✅
compile ✅
knip ✅
platform-unit-test (ubuntu-latest) ✅
platform-unit-test (windows-latest) ✅
integration-test ✅
CodeQL ✅
Analyze (javascript-typescript) ✅

The PR is now ready for review with all critical issues resolved!

roomote bot requested review from cte, jr and mrubens as code owners July 24, 2025 16:11

github-project-automation bot added this to Roo Code Roadmap and Roo Code Roadmap Jul 24, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Jul 24, 2025

github-project-automation bot moved this to Triage in Roo Code Roadmap Jul 24, 2025

dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jul 24, 2025

ellipsis-dev bot reviewed Jul 24, 2025

View reviewed changes

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 24, 2025

roomote bot mentioned this pull request Jul 25, 2025

fix: address Export option issues in PR #6176 #6192

Closed

roomote added 2 commits July 25, 2025 02:13

fix: add missing translations for export feature in all locales

4f49338

ellipsis-dev bot reviewed Jul 25, 2025

View reviewed changes

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 25, 2025

daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jul 25, 2025

hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jul 25, 2025

daniel-lxs moved this from PR [Needs Prelim Review] to PR [Draft / In Progress] in Roo Code Roadmap Jul 28, 2025

daniel-lxs marked this pull request as draft July 28, 2025 21:42

hannesrudolph added PR - Draft / In Progress and removed PR - Needs Preliminary Review labels Jul 28, 2025

hannesrudolph closed this Jul 28, 2025

github-project-automation bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap Jul 28, 2025

github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add export option to slash command menu #6176

feat: add export option to slash command menu #6176

Uh oh!

roomote bot commented Jul 24, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

ellipsis-dev bot Jul 24, 2025

Uh oh!

hannesrudolph commented Jul 25, 2025

Uh oh!

roomote bot commented Jul 25, 2025

Uh oh!

roomote bot commented Jul 25, 2025

Uh oh!

hannesrudolph commented Jul 25, 2025

Uh oh!

roomote bot commented Jul 25, 2025

Uh oh!

ellipsis-dev bot Jul 25, 2025

Uh oh!

roomote bot commented Jul 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	label: "Export current mode",
	label: t("Export current mode"),

	"exportCurrentMode": "Export current mode",
	"exportCurrentMode": "Exporta el mode actual",

feat: add export option to slash command menu #6176

feat: add export option to slash command menu #6176

Uh oh!

Conversation

roomote bot commented Jul 24, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Behavior

Testing

Uh oh!

ellipsis-dev bot Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

hannesrudolph commented Jul 25, 2025

Uh oh!

roomote bot commented Jul 25, 2025

Uh oh!

roomote bot commented Jul 25, 2025

PR Review Summary for #6176: feat: add export option to slash command menu

Executive Summary

Critical Issues (Must Fix)

1. Missing Tests

2. Missing Internationalization (i18n)

Pattern Inconsistencies

1. Inconsistent Option Ordering

2. Missing Icon Consistency Check

Architecture Concerns

1. Dependency on Current Mode State

Minor Suggestions

1. Consider Adding Keyboard Shortcut

2. User Feedback Enhancement

3. Export Option Visibility

Code Quality Observations

Positive Aspects:

Areas for Improvement:

Redundancy Findings

Recommendation

Uh oh!

hannesrudolph commented Jul 25, 2025

Uh oh!

roomote bot commented Jul 25, 2025

Uh oh!

ellipsis-dev bot Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot commented Jul 25, 2025

1. ✅ Added missing tests

2. ✅ Implemented internationalization (i18n)

3. ✅ Fixed option ordering

📊 CI Status: All checks passing ✅

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

roomote bot commented Jul 24, 2025 •

edited by ellipsis-dev bot

Loading